Add 11 and 18 to AN_REQUIRING_PATTERNS, fix for 110 #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using this library to generate descriptions based on ages and found that 18 and 110 were incorrectly indefinitized:
I edited the regex pattern for
11
to include\b
word boundaries so that110
could be excluded, and included a similar pattern for18
to correct the cases above.With this commit, the
\b
boundary would include punctuation for formatted numbers such as18,000
but not18000
:I saw pull request #16 and the regex pattern given in the July 27 comment looks like it could work, as well, but I'm unsure of the status of that PR. That pattern could be a better solution, but I don't know what cases the last block with digit boundaries would match for.
I'd value your feedback if this isn't an appropriate fix, and would be interested in a discussion of a better approach. Thanks!